Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

(2.4) Fix kibana dashboard import #530

Conversation

branden
Copy link
Contributor

@branden branden commented Sep 24, 2020

What type of PR is this?

Bug

What this PR does/ why we need it:

This is a 2.4 backport of #511.

Which issue(s) this PR fixes:

https://jira.d2iq.com/browse/D2IQ-70596

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes an issue that causes Kibana to deploy without an audit log dashboard.

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@branden branden requested a review from a team as a code owner September 24, 2020 16:29
@branden branden self-assigned this Sep 24, 2020
@branden branden requested review from joejulian and a team September 24, 2020 16:29
* Bump kibana addon revision

* Set empty API basepath for dashboard import script

The default basepath is `/`, however this causes the dashboard import
script to make requests to e.g. `//api/status`, which returns a 404.
Removing the extra `/` by emptying the basepath fixes this problem.

* Set dashboard import timeout to 180

This extends the timeout for the dashboard import script to wait for the
API to become available from 60 to 180 seconds.

Co-authored-by: Sam Tran <[email protected]>
(cherry picked from commit c52c38e)
@branden branden force-pushed the branden/kibana-dashboard-import-2.4 branch from e4043eb to d38737c Compare September 24, 2020 16:32
@branden branden added ready backport This is a PR that backports to a branch labels Sep 24, 2020
@joejulian joejulian merged commit bb2b843 into d2iq-archive:release/2.4 Sep 24, 2020
@branden branden deleted the branden/kibana-dashboard-import-2.4 branch September 24, 2020 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport This is a PR that backports to a branch ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants