This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Fix kibana dashboard import #511
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default basepath is `/`, however this causes the dashboard import script to make requests to e.g. `//api/status`, which returns a 404. Removing the extra `/` by emptying the basepath fixes this problem.
This extends the timeout for the dashboard import script to wait for the API to become available from 60 to 180 seconds.
samvantran
approved these changes
Sep 14, 2020
joejulian
approved these changes
Sep 15, 2020
branden
added a commit
to branden/kubernetes-base-addons
that referenced
this pull request
Sep 24, 2020
* Bump kibana addon revision * Set empty API basepath for dashboard import script The default basepath is `/`, however this causes the dashboard import script to make requests to e.g. `//api/status`, which returns a 404. Removing the extra `/` by emptying the basepath fixes this problem. * Set dashboard import timeout to 180 This extends the timeout for the dashboard import script to wait for the API to become available from 60 to 180 seconds. Co-authored-by: Sam Tran <[email protected]>
5 tasks
branden
added a commit
to branden/kubernetes-base-addons
that referenced
this pull request
Sep 24, 2020
* Bump kibana addon revision * Set empty API basepath for dashboard import script The default basepath is `/`, however this causes the dashboard import script to make requests to e.g. `//api/status`, which returns a 404. Removing the extra `/` by emptying the basepath fixes this problem. * Set dashboard import timeout to 180 This extends the timeout for the dashboard import script to wait for the API to become available from 60 to 180 seconds. Co-authored-by: Sam Tran <[email protected]> (cherry picked from commit c52c38e)
joejulian
pushed a commit
that referenced
this pull request
Sep 24, 2020
* Bump kibana addon revision * Set empty API basepath for dashboard import script The default basepath is `/`, however this causes the dashboard import script to make requests to e.g. `//api/status`, which returns a 404. Removing the extra `/` by emptying the basepath fixes this problem. * Set dashboard import timeout to 180 This extends the timeout for the dashboard import script to wait for the API to become available from 60 to 180 seconds. Co-authored-by: Sam Tran <[email protected]> (cherry picked from commit c52c38e)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug
What this PR does/ why we need it:
This fixes the dashboard import script for Kibana by overriding a couple default chart values. It sets
dashboardImport.basePathto an empty string to prevent the dashboard import script from making requests to locations that return 404. It also increases the timeout from 60 to 180 seconds to give the Kibana API more time to become ready before the import script executes.The dashboard import script's API queries are returning 404 because it requests paths with an extra beginning slash, e.g.
//api/status. This worked until we upgraded Kibana from 6.8.2 to 6.8.10. Kibana 6.8.7 upgrades nodejs to 10.19.0, which introduces stricter HTTP parsing, which may explain the change. The Kibana chart deploys Kibana 6.7.0 by default, which is likely why the upstream bug hasn't been fixed yet.Which issue(s) this PR fixes:
https://jira.d2iq.com/browse/D2IQ-71039
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist