Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

[release/4][BACKPORT] [prometheus] bump to chart containing elasticsearch alertmanager rules #1223

Closed
wants to merge 11 commits into from

Conversation

d2iq-mergebot
Copy link
Contributor

This is a backport of the following PR:

#1209

What type of PR is this?

Chore

What this PR does/ why we need it:

Allows the creation of elasticsearch rules to fire in alertmanager

Which issue(s) this PR fixes:

https://jira.d2iq.com/browse/D2IQ-76519

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

prometheus: possible to enable elasticsearch rules 

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@d2iq-mergebot
Copy link
Contributor Author

This repo has @mesosphere-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@mesosphere-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.

@mesosphere-mergebot backport  

Copy link
Contributor

@gracedo gracedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to update the values.chart.helm.kubeaddons.mesosphere.io/prometheus annotation here

@branden branden self-requested a review June 21, 2021 17:07
@branden branden added the backport This is a PR that backports to a branch label Jun 21, 2021
@alejandroEsc alejandroEsc requested a review from gracedo June 21, 2021 17:32
@alejandroEsc alejandroEsc added this to the release/next milestone Jun 21, 2021
@branden branden modified the milestones: release/next, release/4.2 Jun 21, 2021
@joejulian joejulian changed the base branch from release/4.1 to release/4 August 13, 2021 02:08
@joejulian joejulian changed the title [release/4.1][BACKPORT] [prometheus] bump to chart containing elasticsearch alertmanager rules [release/4][BACKPORT] [prometheus] bump to chart containing elasticsearch alertmanager rules Aug 13, 2021
@joejulian
Copy link
Contributor

/test-all

@joejulian
Copy link
Contributor

lol, no wonder tests aren't running. This is already in release/4. Closing.

@joejulian joejulian closed this Aug 13, 2021
@joejulian joejulian deleted the backport/release/4.1/master-1209 branch August 13, 2021 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
addon/prometheus backport This is a PR that backports to a branch ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants