Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

[prometheus] bump to chart containing elasticsearch alertmanager rules #1209

Merged
merged 4 commits into from
Jun 21, 2021

Conversation

alejandroEsc
Copy link
Contributor

What type of PR is this?

Chore

What this PR does/ why we need it:

Allows the creation of elasticsearch rules to fire in alertmanager

Which issue(s) this PR fixes:

https://jira.d2iq.com/browse/D2IQ-76519

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

prometheus: possible to enable elasticsearch rules 

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@alejandroEsc alejandroEsc self-assigned this Jun 15, 2021
@alejandroEsc alejandroEsc requested review from a team as code owners June 15, 2021 14:58
@d2iq-mergebot
Copy link
Contributor

This repo has @mesosphere-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@mesosphere-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.

@mesosphere-mergebot backport  

Copy link
Contributor

@gracedo gracedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need an update to values annotation otherwise lgtm

@alejandroEsc
Copy link
Contributor Author

need an update to values annotation otherwise lgtm

Sorry which ones?

@alejandroEsc
Copy link
Contributor Author

@mesosphere-mergebot backport release/4.1

@d2iq-mergebot
Copy link
Contributor

Backport PR for release/4.1: #1223

@alejandroEsc alejandroEsc enabled auto-merge (squash) June 21, 2021 14:34
@branden
Copy link
Contributor

branden commented Jun 21, 2021

I think we need to update the values.chart.helm.kubeaddons.mesosphere.io/prometheus annotation since the chart bump brings a different set of default values. Otherwise LGTM.

@alejandroEsc
Copy link
Contributor Author

I think we need to update the values.chart.helm.kubeaddons.mesosphere.io/prometheus annotation since the chart bump brings a different set of default values. Otherwise LGTM.

OHHH sorry! good point, ok will do.

@alejandroEsc alejandroEsc merged commit 7275b90 into master Jun 21, 2021
@alejandroEsc alejandroEsc deleted the ae/es/rules branch June 21, 2021 17:31
@alejandroEsc
Copy link
Contributor Author

@mesosphere-mergebot backport release/4

@d2iq-mergebot
Copy link
Contributor

Backport PR for release/4: #1224

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants