-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add timeout period to retry error message #9123
Conversation
Thanks for taking the time to open a PR!
|
I'm planning to ask some of the team members about the wording here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, just wanted to verify the wording before you invest more time into the PR. Should be good to move forward with the suggested changes.
1794f80
to
ce6188e
Compare
Flaky failures. |
Rebased and merged conflicts. Flaky failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry. I thought I commented in here, but I must have forgotten. We decided to go back to the colons :
because after seeing the changes there are some error messages that are strangely capitalized like.
Timed out retrying after 4000ms. cy.click() failed...
Timed out retrying after 50ms. expected '<button>'...
So they should be:
Timed out retrying after 4000ms: cy.click() failed...
Timed out retrying after 50ms: expected '<button>'
User facing changelog
Retry timeout error message now contains timeout period.
Additional details
How has the user experience changed?
Before:
After:
Questions
I intentionally stopped the CI because there are some problems to solve.
Without these questions cleared, editing error messages in the tests is meaningless.
PR Tasks