Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Timed out Retrying" should indicate timeout value #5781

Closed
Masterxilo opened this issue Nov 23, 2019 · 2 comments · Fixed by #9123
Closed

"Timed out Retrying" should indicate timeout value #5781

Masterxilo opened this issue Nov 23, 2019 · 2 comments · Fixed by #9123
Labels
pkg/driver This is due to an issue in the packages/driver directory type: enhancement Requested enhancement of existing feature type: error message

Comments

@Masterxilo
Copy link

Masterxilo commented Nov 23, 2019 •
edited by jennifer-shehane
Loading

I just started using Cypress in the last 30 min and already love it.

I love the work put into the custom error messages and would like to contribute.

I just wrote my first test asserting that

cy.get('body').contains('VERSION=latest2', {timeout: 10000})

which failed with

CypressError: Timed out retrying: Expected to find content: 'VERSION=latest2' within the element: but never did.

In the future, I think I would have an easier time troubleshooting this if the error mentioned the timeout that was specified:

CypressError: Timed out retrying: Expected to find content: 'VERSION=latest2' within the element: within 10 seconds but didn't during this time.

Thanks for your time.
@cypress-bot cypress-bot bot added the stage: proposal 💡 No work has been done of this issue label Jan 2, 2020
@jennifer-shehane jennifer-shehane added type: error message pkg/driver This is due to an issue in the packages/driver directory type: enhancement Requested enhancement of existing feature and removed stage: proposal 💡 No work has been done of this issue labels Jan 2, 2020
@sainthkh sainthkh mentioned this issue Nov 9, 2020
Merged
2 tasks
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Nov 9, 2020
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: needs review The PR code is done & tested, needs review labels Nov 19, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: work in progress stage: needs review The PR code is done & tested, needs review labels Dec 14, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 16, 2020

The code for this is done in cypress-io/cypress#9123, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Dec 16, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 21, 2020

Released in 6.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
pkg/driver This is due to an issue in the packages/driver directory type: enhancement Requested enhancement of existing feature type: error message
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add timeout period to retry error message sainthkh/cypress
2 participants
@jennifer-shehane @Masterxilo