Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not silence cli commands #6909

Merged
merged 3 commits into from
Apr 1, 2020
Merged

Do not silence cli commands #6909

merged 3 commits into from
Apr 1, 2020

Conversation

bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Apr 1, 2020

User facing changelog

Cypress no longer hides output from these commands when npm log level is silent or warn

  • cypress --version
  • cypress version
  • cypress cache path
  • cypress cache list

Additional details

this PR does not refactor the entire log or touch install progress messages like #2706 so the change should be easy to merge

How has the user experience changed?

before

No output when running commands. For example from our Docker images

$ docker run -it --entrypoint=cypress cypress/included:4.2.0 --version
~/git/cypress-docker-images on master

after
prints versions

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 1, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@bahmutov bahmutov requested a review from kuceb April 1, 2020 15:28
@cypress
Copy link

cypress bot commented Apr 1, 2020



Test summary

7031 1 98 0


Run details

Project cypress
Status Failed
Commit 7458bdc
Started Apr 1, 2020 3:28 PM
Ended Apr 1, 2020 3:35 PM
Duration 07:32 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

cypress/integration/commands/connectors_spec.coffee Failed
1 ... > assertion verification > eventually passes the assertion

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@bahmutov bahmutov merged commit 3b65143 into develop Apr 1, 2020
@emilyrohrbough emilyrohrbough deleted the do-not-silence-cli-commands branch August 1, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm_config_loglevel env variable is silencing too much (--silent)
2 participants