Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm_config_loglevel env variable is silencing too much (--silent) #2705

Closed
kuceb opened this issue Nov 1, 2018 · 5 comments · Fixed by #6909
Closed

npm_config_loglevel env variable is silencing too much (--silent) #2705

kuceb opened this issue Nov 1, 2018 · 5 comments · Fixed by #6909

Comments

@kuceb
Copy link
Contributor

kuceb commented Nov 1, 2018

Bug

introduced by #817

Current:
npm_config_loglevel is able to silent the stdout from cypress version, cypress cache list, cypress downloading message, etc

Desired:
presence of npm_config_loglevel should not silence important messages such as the downloading message, and output from cypress version and cypress cache list, etc

@kuceb kuceb added the type: bug label Nov 1, 2018
@kuceb kuceb self-assigned this Nov 1, 2018
@jennifer-shehane jennifer-shehane added stage: needs review The PR code is done & tested, needs review and removed stage: in progress labels Jan 23, 2019
@isolationism
Copy link

I respectfully disagree.

Disrespect for this key property means a flood of literally millions of lines of useless logfile output in a container deploy scenario:

[20:22:06]  Unzipping Cypress        99% 1s [title changed]
[20:22:06]  Unzipping Cypress        99% 1s [title changed]
[20:22:06]  Unzipping Cypress        99% 1s [title changed]
[20:22:06]  Unzipping Cypress        99% 1s [title changed]
... forever ...

I would paste the entire buffer, but I don't think the megabytes of data are valuable — do you?

In fact, you might rightfully surmise that it goes a long way toward obscuring actually useful log information by spamming log files with worthless garbage data, obliterating terminal scrollback buffers, and so on.

If you want to WARN people about a large/potentially long download, fine — you get one line. The current implementation is a massive waste of resources with no benefit whatsoever. Don't ram it down users' throats.

To wit: Nobody is silencing output because they are waiting on baited breath for how long the process is going to take.

@kuceb
Copy link
Contributor Author

kuceb commented Sep 20, 2019

@isolationism I understand your frustration, the idea here is to print the 6 lines of output when the log level is set to silent. We already try to do this in CI and when no tty, but clearly there are bugs there. and I'm not sure why we haven't fixed the 1000's of lines of output when we detect a tty, I believe there is a PR for it

@cypress-bot cypress-bot bot added stage: ready for work The issue is reproducible and in scope and removed stage: needs review The PR code is done & tested, needs review labels Mar 17, 2020
@bahmutov
Copy link
Contributor

bahmutov commented Apr 1, 2020

I am fine with download progress messages, but I think we are silencing important stuff that user is asking for:

  • cypress --version
  • cypress version
  • cypress cache path
  • cypress cache list

@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Apr 1, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 1, 2020

The code for this is done in cypress-io/cypress#6909, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Apr 1, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 13, 2020

Released in 4.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants