Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert aws sdk PR #28379

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

jordanpowell88
Copy link
Contributor

@jordanpowell88 jordanpowell88 commented Nov 21, 2023

Reverts this PR that broke the Uploading the Binary to S3.

This was intended to release as part of 13.6.0

Copy link

cypress bot commented Nov 21, 2023

2 failed and 4 flaky tests on run #52451 ↗︎

2 552 6 0 Flakiness 4

Details:

add missing dep
Project: cypress Commit: 5dd7160b99
Status: Failed Duration: 13:01 💡
Started: Nov 21, 2023 8:12 PM Ended: Nov 21, 2023 8:25 PM
Failed  cypress/e2e/runs.cy.ts • 2 failed tests • app-e2e

View Output

Test Artifacts
App: Runs > Runs - Create Project > when a project is created, injects new projectId into the config file, and sends expected UTM params Test Replay Screenshots
App: Runs > Runs - Cannot Find Project > opens Connect Project modal after clicking Reconnect Project button Test Replay Screenshots
Flakiness  runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
... > displays each run with correct information Test Replay Screenshots
Flakiness  cypress-in-cypress.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
Cypress in Cypress > restarts browser if there is a before:browser:launch task and there is a change on the config Test Replay Screenshots
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Screenshots
Flakiness  debug.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App - Debug Page > shows running and updating build Test Replay Screenshots

Review all test suite changes for PR #28379 ↗︎

@jennifer-shehane jennifer-shehane merged commit 9337e4e into develop Nov 21, 2023
74 of 80 checks passed
@jennifer-shehane jennifer-shehane deleted the jordanpowell88/revert-aws-pr branch November 21, 2023 20:26
@trivikr
Copy link
Contributor

trivikr commented Nov 21, 2023

The failed CI https://app.circleci.com/pipelines/github/cypress-io/cypress-publish-binary/3407/workflows/4f2225d3-8591-48d7-bb0e-d8a572e6490a/jobs/6045 is not loading for me. Not sure if it's a permissions issue.

If you can access it, can you provide a stack trace here, so that whoever is taking it up in future has context?

@jennifer-shehane
Copy link
Member

@trivikr providing the logs

#uploadBuildArtifact
Upload options
{
  type: 'binary',
  version: '13.6.0',
  file: 'cypress.zip',
  hash: 'develop-xxx'
}
#uploadToS3 ⏳
uploading cypress.zip to beta/binary/13.6.0/linux-x64/develop-xxx/cypress.zip
[12:40:00] gulp-debug: beta/binary/13.6.0/linux-x64/develop-xxx/cypress.zip
[12:40:00] gulp-debug: 1 item
[12:40:02] [create] beta/binary/13.6.0/linux-x64/develop-xxx/cypress.zip
setting checksum for file cypress.zip
on s3 object beta/binary/13.6.0/linux-x64/develop-xxx/cypress.zip
SHA256 checksum xxx
size 182954653
There was an issue uploading the artifact.
🔥 deploy error
Error: Region is missing
    at default (/root/cypress/node_modules/@smithy/config-resolver/dist-cjs/regionConfig/config.js:10:15)
    at /root/cypress/node_modules/@smithy/node-config-provider/dist-cjs/fromStatic.js:6:83
    at /root/cypress/node_modules/@smithy/property-provider/dist-cjs/chain.js:12:39
    at async coalesceProvider (/root/cypress/node_modules/@smithy/property-provider/dist-cjs/memoize.js:14:24)
    at async /root/cypress/node_modules/@smithy/property-provider/dist-cjs/memoize.js:26:28
    at async region (/root/cypress/node_modules/@smithy/config-resolver/dist-cjs/regionConfig/resolveRegionConfig.js:17:36)
    at async /root/cypress/node_modules/@aws-sdk/middleware-sdk-s3/dist-cjs/region-redirect-endpoint-middleware.js:6:32
    at async /root/cypress/node_modules/@aws-sdk/middleware-sdk-s3/dist-cjs/region-redirect-middleware.js:9:20
    at async /root/cypress/node_modules/@aws-sdk/middleware-logger/dist-cjs/loggerMiddleware.js:7:26

@emilyrohrbough emilyrohrbough mentioned this pull request Jan 12, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants