-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate AWS SDK for JavaScript v2 APIs to v3 in scripts folder #28249
Merged
jennifer-shehane
merged 10 commits into
cypress-io:develop
from
trivikr:aws-sdk-js-codemod
Nov 21, 2023
Merged
chore: migrate AWS SDK for JavaScript v2 APIs to v3 in scripts folder #28249
jennifer-shehane
merged 10 commits into
cypress-io:develop
from
trivikr:aws-sdk-js-codemod
Nov 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc active contributors @emilyrohrbough @jennifer-shehane |
emilyrohrbough
approved these changes
Nov 16, 2023
mschile
approved these changes
Nov 20, 2023
We needed to revert this PR as it broke the CI job that uploads to S3 (see https://app.circleci.com/pipelines/github/cypress-io/cypress-publish-binary/3407/workflows/4f2225d3-8591-48d7-bb0e-d8a572e6490a/jobs/6045). We should add this back in AND add appropriate tests to make sure this doesn't happen again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
From AWS SDK for JavaScript v2 README:
This PR migrates AWS SDK for JavaScript v2 APIs to v3 using aws-sdk-js-codemod.
$ npx [email protected] -t v2-to-v3 scripts/binary/s3-api.ts
Steps to test
N/A
How has the user experience changed?
N/A
PR Tasks
cypress-documentation
?type definitions
?