-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: proxy issues with service workers and clean up at end of specs #28060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthemanuel
requested review from
chrisbreiding,
mschile and
cacieprins
and removed request for
mschile
October 16, 2023 19:17
chrisbreiding
approved these changes
Oct 17, 2023
ryanthemanuel
commented
Oct 17, 2023
ryanthemanuel
commented
Oct 17, 2023
ryanthemanuel
commented
Oct 17, 2023
ryanthemanuel
commented
Oct 17, 2023
mschile
reviewed
Oct 17, 2023
ryanthemanuel
commented
Oct 17, 2023
mschile
reviewed
Oct 17, 2023
mschile
reviewed
Oct 17, 2023
mschile
reviewed
Oct 17, 2023
mschile
reviewed
Oct 17, 2023
mschile
reviewed
Oct 17, 2023
mschile
approved these changes
Oct 17, 2023
1 task
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR fixes a performance regression with proxy correlations and service workers. Specifically this PR:
Steps to test
Several system tests were added to cover the scenarios involved
How has the user experience changed?
Performance should improve in scenarios where there are service workers
PR Tasks
cypress-documentation
?type definitions
?