fix: undo timeout change to fix performance regression #28075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
We introduced a regression by bumping up the timeout on proxy correlation. The thought was that the majority of requests should be correlated quickly and for the occasional ones that take a while, it is more important to actually correlate for things like assets in test replay and intercepts. Unfortunately, there are still bugs in the proxy correlation logic that cause some requests to never be able to be correlated. Specifically requests that come from service workers. We originally thought this would be a fairly fast fix to this problem; however it ended up being more nuanced than we thought so we are backing out the change that caused the regression while we work on a more robust solution.
Steps to test
n/a
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?