Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix windows regression #27025

Merged
merged 6 commits into from
Jun 14, 2023
Merged

chore: fix windows regression #27025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c8a09e9
chore: fix flaky windows tests
lmiller1990 Jun 12, 2023
3abcbd2
Merge branch 'develop' of https://github.com/cypress-io/cypress into …
lmiller1990 Jun 13, 2023
f506637
Merge branch 'develop' of https://github.com/cypress-io/cypress into …
lmiller1990 Jun 13, 2023
cd95b28
Merge branch 'develop' of https://github.com/cypress-io/cypress into …
lmiller1990 Jun 13, 2023
ae8201e
chore: fix windows CI
lmiller1990 Jun 13, 2023
7e4b0d8
ci file
lmiller1990 Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/workflows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ linuxArm64WorkflowFilters: &linux-arm64-workflow-filters
- equal: [ develop, << pipeline.git.branch >> ]
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- equal: [ 'lmiller/fix-windows-regressions', << pipeline.git.branch >> ]
- equal: [ 'matth/feat/chrome-headless', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
Expand Down
4 changes: 3 additions & 1 deletion packages/app/cypress/e2e/cypress-in-cypress.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,8 +403,10 @@ describe('Cypress in Cypress', { viewportWidth: 1500, defaultCommandTimeout: 100
cy.contains('E2E specs').should('be.visible')

cy.withCtx(async (ctx) => {
const currentProject = ctx.currentProject?.replaceAll('\\', '/')
const specPath = `${currentProject}/cypress/e2e/dom-content.spec.js`
const url = `http://127.0.0.1:${ctx.gqlServerPort}/__launchpad/graphql?`
const payload = `{"query":"mutation{\\nrunSpec(specPath:\\"${ctx.currentProject}/cypress/e2e/dom-content.spec.js\\"){\\n__typename\\n... on RunSpecResponse{\\ntestingType\\nbrowser{\\nid\\nname\\n}\\nspec{\\nid\\nname\\n}\\n}\\n}\\n}","variables":null}`
const payload = `{"query":"mutation{\\nrunSpec(specPath:\\"${specPath}\\"){\\n__typename\\n... on RunSpecResponse{\\ntestingType\\nbrowser{\\nid\\nname\\n}\\nspec{\\nid\\nname\\n}\\n}\\n}\\n}","variables":null}`

ctx.coreData.app.browserStatus = 'open'

Expand Down
2 changes: 1 addition & 1 deletion packages/graphql/schemas/schema.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1754,7 +1754,7 @@ type Mutation {
"""
runSpec(
"""
Relative path of spec to run from Cypress project root - must match e2e or component specPattern
Absolute path of the spec to run - must match e2e or component specPattern
"""
specPath: String!
): RunSpecResult
Expand Down