Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix windows regression #27025

Merged
merged 6 commits into from
Jun 14, 2023
Merged

Conversation

lmiller1990
Copy link
Contributor

  • Closes N/A

Additional details

Fix regression in Windows CI introduced in https://github.com/cypress-io/cypress/pull/26973/files. CI: https://app.circleci.com/pipelines/github/cypress-io/cypress/53618/workflows/4bfd1c4d-14ae-43fd-9e25-08a78f7b5d99/jobs/2212016/tests#failed-test-0

There are two failures. One is a real regression, one is flake.

Steps to test

Ensure Windows CI is passing.

How has the user experience changed?

PR Tasks

@cypress
Copy link

cypress bot commented Jun 13, 2023

4 flaky tests on run #47617 ↗︎

0 468 6 0 Flakiness 4

Details:

ci file
Project: cypress Commit: 7e4b0d82f2
Status: Passed Duration: 13:35 💡
Started: Jun 14, 2023 4:58 AM Ended: Jun 14, 2023 5:12 AM
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video
Flakiness  cypress-in-cypress-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress CT > default config > redirects to the specs list with error if a spec is not found Output Screenshots Video
Flakiness  debug.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App - Debug Page > all tests passed Output Screenshots Video
Flakiness  cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@lmiller1990 lmiller1990 requested a review from a team June 14, 2023 06:18
@chrisbreiding chrisbreiding merged commit fb08c6e into develop Jun 14, 2023
@chrisbreiding chrisbreiding deleted the lmiller/fix-windows-regressions branch June 14, 2023 12:55
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 20, 2023

Released in 12.15.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.15.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants