-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix issue with logs without wallClockStartedAt #26473
Merged
mschile
merged 1 commit into
feat/protocol
from
mschile/protocol/command_log_updated_at
Apr 11, 2023
Merged
chore: fix issue with logs without wallClockStartedAt #26473
mschile
merged 1 commit into
feat/protocol
from
mschile/protocol/command_log_updated_at
Apr 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschile
changed the title
chore: fix issue with logs without wallClockUpdatedAt
chore: fix issue with logs without wallClockStartedAt
Apr 10, 2023
AtofStryker
approved these changes
Apr 11, 2023
ryanthemanuel
approved these changes
Apr 11, 2023
6 flaky tests on run #45469 ↗︎
Details:
commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkitcypress/cypress.cy.js • 3 flaky tests • 5x-driver-webkit
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
tgriesser
added a commit
that referenced
this pull request
Apr 25, 2023
* feat/protocol: (45 commits) chore: adding support for url:changed (#26519) chore: adding viewport:changed to protocol (#26508) chore: Reduce dependencies and binary size, add circle ci detector (#26522) chore: 12.10.0 release (#26517) test: fix flaky tests (#26505) chore: Check project dependencies for CT compatibility (#26497) chore: update vm2 to 3.9.16 (#26489) chore: enable builds on feat/protocol branch (#26506) chore: [skip ci] update to labels looked at by stalebot (#26496) chore: connecting to electron browser (#26471) chore: [skip ci] turning on stale bot (#26488) chore: fix issue with logs without wallClockUpdatedAt (#26473) Update triage_add_to_project.yml chore: Update Chrome (stable) to 112.0.5615.49 and Chrome (beta) to 113.0.5672.24 (#26434) feat: display framework definition errors (#26183) fix: correctly resolve dependencies for CT onboarding when using Yarn Plug n Play (#26452) fix: Subscribe to framework detection changes in wizard (#26437) fix: make clicks on type('{enter}') composed (#26395) chore: update add-to-project workflow (#26439) chore: Pass telemetry resources from the node process to the browser (#26468) ...
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
wallClockStartedAt
(e.g. anagent
log), thewallClockUpdatedAt
value will now default to the current date/time.Steps to test
spies_stubs_clocks.cy.js
scaffold test and verify no schema errors are thrown.How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?