fix: make clicks on type('{enter}') composed #26395

kgroat · 2023-04-02T14:00:31Z

Closes Firing click events by calling .type('{enter}') on an element inside a shadow root doesn't propagate outside shadow root #26392

Additional details

When typing {enter} in a shadow root, the click event it generates doesn't propagate through shadow roots. This PR fixes that by setting composed: true. See https://developer.mozilla.org/en-US/docs/Web/API/Event/composed

Steps to test

Clone https://github.com/kgroat/cypress-enter-repro and run the tests.

How has the user experience changed?

The UX has remain unchanged, just that the click event propagates through shadow roots.

PR Tasks

Have tests been added/updated?
[na] Has a PR for user-facing changes been opened in cypress-documentation?
[na] Have API changes been updated in the type definitions?

kgroat · 2023-04-04T15:33:36Z

I noticed that the test file I updated (packages/driver/cypress/e2e/commands/actions/type_events_spec.js) doesn't have .cy. in it, so it isn't getting picked up by cypress & run locally. Is this something I should fix here, or is that something I should just leave alone?

cypress · 2023-04-04T16:02:11Z

1 failed and 29 flaky tests on run #45243 ↗︎

1	26908	1281	0	29

Details:

Merge branch 'develop' into issue-26392-make-click-composed
Project: cypress	Commit: `74937f146d`
Status: Failed	Duration: 19:32 💡
Started: Apr 4, 2023 3:42 PM	Ended: Apr 4, 2023 4:02 PM

cypress/e2e/e2e/origin/commands/waiting.cy.ts • 1 failed test • 5x-driver-electron

View Output Video

Test		Artifacts
cy.origin waiting > alias > waits for the route alias to have a response		`Output` `Video`

create-from-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test		Artifacts
... > runs generated spec		`Output` `Screenshots` `Video`

specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test		Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs		`Output` `Screenshots` `Video`

cypress-in-cypress-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test		Artifacts
Cypress In Cypress CT > default config > redirects to the specs list with error if a spec is not found		`Output` `Screenshots` `Video`

cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output Video

Test		Artifacts
Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution		`Output` `Screenshots` `Video`

commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test		Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse		`Output`

The first 5 flaky specs are shown, see all 17 specs in Cypress Cloud.

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

marktnoonan · 2023-04-04T17:37:59Z

@kgroat good eye! Please update the filename to include cy and let's see what happens, this seems like it might have been an oversight

kgroat · 2023-04-04T21:09:44Z

I don't understand what this error means in the Semantic Pull Request job:

Error: Expected line number 17 to be a line break

I've tried modifying the title & description of the PR but nothing makes it go away.

astone123 · 2023-04-04T21:23:04Z

@kgroat sorry about that, we had merged a change in that had an incorrect changelog. I just merged a commit into develop to fix it and just synced the PR so we should be good on that

kgroat · 2023-04-05T15:13:50Z

It looks like renaming commands/actions/type_events.cy.js is causing some failures in CI. Should I rename it back & move my test into a different file, or what is the path forward?

astone123 · 2023-04-05T19:50:55Z

@kgroat it looks like those tests are failing on the Webkit browser. Adding this spec back might have uncovered an issue. In the interest of moving this forward, I'm going to try to exclude this specific spec from running on Webkit and make a follow up issue to fix that

packages/driver/cypress/e2e/commands/actions/type_events.cy.js

Co-authored-by: Mike Plummer <[email protected]>

astone123 · 2023-04-06T22:00:54Z

I'm trying to figure out why component tests are failing on this branch. That's the only thing keeping this from merging

cli/CHANGELOG.md

Co-authored-by: Emily Rohrbough <[email protected]>

astone123 · 2023-04-10T21:25:52Z

The failures on run-app-component-tests-chrome are unrelated to this PR

* fix: make clicks on type('{enter}') composed Co-authored-by: Mike Plummer <[email protected]> * disable failing type_events driver tests from running in Webkit * make sure done is only called once * use test configuration to disable on webkit * fix changelog * Update cli/CHANGELOG.md Co-authored-by: Emily Rohrbough <[email protected]> --------- Co-authored-by: Adam Stone-Lord <[email protected]> Co-authored-by: Mike Plummer <[email protected]> Co-authored-by: Emily Rohrbough <[email protected]> Co-authored-by: Ben M <[email protected]>

* feat/protocol: (45 commits) chore: adding support for url:changed (#26519) chore: adding viewport:changed to protocol (#26508) chore: Reduce dependencies and binary size, add circle ci detector (#26522) chore: 12.10.0 release (#26517) test: fix flaky tests (#26505) chore: Check project dependencies for CT compatibility (#26497) chore: update vm2 to 3.9.16 (#26489) chore: enable builds on feat/protocol branch (#26506) chore: [skip ci] update to labels looked at by stalebot (#26496) chore: connecting to electron browser (#26471) chore: [skip ci] turning on stale bot (#26488) chore: fix issue with logs without wallClockUpdatedAt (#26473) Update triage_add_to_project.yml chore: Update Chrome (stable) to 112.0.5615.49 and Chrome (beta) to 113.0.5672.24 (#26434) feat: display framework definition errors (#26183) fix: correctly resolve dependencies for CT onboarding when using Yarn Plug n Play (#26452) fix: Subscribe to framework detection changes in wizard (#26437) fix: make clicks on type('{enter}') composed (#26395) chore: update add-to-project workflow (#26439) chore: Pass telemetry resources from the node process to the browser (#26468) ...

kgroat changed the title ~~Make clicks on type('{enter}') composed~~ fix: make clicks on type('{enter}') composed Apr 2, 2023

kgroat force-pushed the issue-26392-make-click-composed branch from 478da43 to 70af6f1 Compare April 2, 2023 14:07

kgroat marked this pull request as ready for review April 4, 2023 15:32

nagash77 assigned astone123 Apr 4, 2023

kgroat changed the title ~~fix: make clicks on type('{enter}') composed~~ fix: make clicks on typing enter composed Apr 4, 2023

kgroat changed the title ~~fix: make clicks on typing enter composed~~ fix: make clicks on type('{enter}') composed Apr 4, 2023

Pickra mentioned this pull request Apr 4, 2023

sl-select slot aria attributes violate accessibility shoelace-style/shoelace#1287

Closed

astone123 requested review from chrisbreiding and AtofStryker April 5, 2023 13:54

astone123 mentioned this pull request Apr 5, 2023

Fix type_events driver tests in Webkit #26438

Closed

chrisbreiding requested changes Apr 6, 2023

View reviewed changes

packages/driver/cypress/e2e/commands/actions/type_events.cy.js Outdated Show resolved Hide resolved

astone123 force-pushed the issue-26392-make-click-composed branch from 932b4e0 to 8c27f98 Compare April 6, 2023 16:04

kgroat and others added 7 commits April 6, 2023 10:06

fix: make clicks on type('{enter}') composed

60ebec1

Update changelog

72620b4

Rename type_events_spec.js to type_events.cy.js

ff12055

chore: fix changelog spacing (cypress-io#26430)

c4efabd

Co-authored-by: Mike Plummer <[email protected]>

disable failing type_events driver tests from running in Webkit

92c903a

make sure done is only called once

124e9d7

use test configuration to disable on webkit

a457704

astone123 force-pushed the issue-26392-make-click-composed branch from 8c27f98 to a457704 Compare April 6, 2023 16:08

fix changelog

1d2b9cc

astone123 requested a review from chrisbreiding April 6, 2023 16:10

chrisbreiding approved these changes Apr 6, 2023

View reviewed changes

AtofStryker approved these changes Apr 6, 2023

View reviewed changes

emilyrohrbough reviewed Apr 7, 2023

View reviewed changes

cli/CHANGELOG.md Outdated Show resolved Hide resolved

kgroat and others added 3 commits April 7, 2023 10:03

Update cli/CHANGELOG.md

518f3ab

Co-authored-by: Emily Rohrbough <[email protected]>

Merge branch 'develop' into issue-26392-make-click-composed

3e5e9f6

Merge branch 'develop' into issue-26392-make-click-composed

c0ff4d4

nagash77 merged commit 92542ea into cypress-io:develop Apr 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: make clicks on type('{enter}') composed #26395

fix: make clicks on type('{enter}') composed #26395

kgroat commented Apr 2, 2023 •

edited

Loading

kgroat commented Apr 4, 2023 •

edited

Loading

cypress bot commented Apr 4, 2023

marktnoonan commented Apr 4, 2023

kgroat commented Apr 4, 2023

astone123 commented Apr 4, 2023

kgroat commented Apr 5, 2023

astone123 commented Apr 5, 2023

astone123 commented Apr 6, 2023

astone123 commented Apr 10, 2023

fix: make clicks on type('{enter}') composed #26395

fix: make clicks on type('{enter}') composed #26395

Conversation

kgroat commented Apr 2, 2023 • edited Loading

Additional details

Steps to test

How has the user experience changed?

PR Tasks

kgroat commented Apr 4, 2023 • edited Loading

cypress bot commented Apr 4, 2023

1 failed and 29 flaky tests on run #45243 ↗︎

marktnoonan commented Apr 4, 2023

kgroat commented Apr 4, 2023

astone123 commented Apr 4, 2023

kgroat commented Apr 5, 2023

astone123 commented Apr 5, 2023

astone123 commented Apr 6, 2023

astone123 commented Apr 10, 2023

kgroat commented Apr 2, 2023 •

edited

Loading

kgroat commented Apr 4, 2023 •

edited

Loading