Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cy commands with options object should not display as Object{N} in the Command Log #678

Closed
bahmutov opened this issue Sep 21, 2017 · 5 comments
Closed

cy commands with options object should not display as Object{N} in the Command Log #678

bahmutov opened this issue Sep 21, 2017 · 5 comments
Labels
pkg/reporter This is due to an issue in the packages/reporter directory pkg/server This is due to an issue in the packages/server directory stale no activity on this issue for a long period type: bug

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Sep 21, 2017 •
edited by jennifer-shehane
Loading

Current behavior:

Prints visit "Object{4}" ? this is confusing because I only passed single timeout option and I cannot see the fields in that object. Devtools does not show anything on click

Desired behavior:

  • print ...?
  • print only non-default options?
  • serialize the object to print VISIT {timeout: 20000} for example in this case

How to reproduce:

Do cy.visit with extra options, like below

Test code:

cy.visit("/", {timeout: 20000})

Additional Info (images, stack traces, etc)

screen shot 2017-09-21 at 8 49 52 am

screen shot 2017-09-21 at 8 50 32 am

  • Operating System: mac
  • Cypress Version: 0.20.0
  • Browser Version: electron
@bahmutov bahmutov added type: bug pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory labels Sep 21, 2017
@lilaconlee lilaconlee self-assigned this Oct 22, 2018
@lilaconlee lilaconlee mentioned this issue Nov 1, 2018
Closed
@lilaconlee lilaconlee added this to the Sprint 9 milestone Nov 5, 2018
@chrisbreiding chrisbreiding modified the milestones: Sprint 9, Sprint 12 Nov 20, 2018
@jennifer-shehane jennifer-shehane modified the milestones: Sprint 12, Sprint 13 Nov 26, 2018
@chrisbreiding chrisbreiding mentioned this issue Nov 28, 2018
Closed
@chrisbreiding chrisbreiding modified the milestones: Sprint 13, Sprint 14 Dec 3, 2018
@chrisbreiding chrisbreiding modified the milestones: Sprint 14, Sprint 15 Dec 10, 2018
@chrisbreiding chrisbreiding modified the milestones: Sprint 15, Sprint 18 Jan 7, 2019
@jennifer-shehane jennifer-shehane added stage: proposal 💡 No work has been done of this issue stage: ready for work The issue is reproducible and in scope and removed stage: in progress stage: proposal 💡 No work has been done of this issue labels Jan 23, 2019
flotwig added a commit that referenced this issue Feb 21, 2019
@flotwig
driver: shows URL and not object in command log (fixes part of #678)
cd1f6f1
flotwig added a commit that referenced this issue Feb 26, 2019
@flotwig
driver: shows URL and not object in command log (fixes part of #678)
3b1d9de
flotwig added a commit that referenced this issue Feb 27, 2019
@flotwig
Visit with a POST and/or custom headers (#3489)
d24285b 
* driver, server: visit with a POST [wip]

* driver, server: allow sending body, headers, method in .visit

* driver: test: doublequotes

* driver: api cleanup, error handling

* driver, server: tests

* driver: only recognize visit(opts) if options is sole argument

* server: don't confuse options

* driver: validate method passed to 'visit'

* driver: validate that headers is an object

* driver: shows URL and not object in command log (fixes part of #678)

* cli: add new cy.visit(opts) invocation
@pmelab pmelab mentioned this issue Jun 13, 2019
Closed
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: needs review The PR code is done & tested, needs review labels Feb 12, 2020
@sainthkh sainthkh mentioned this issue Jun 16, 2020
Closed
3 tasks
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: work in progress stage: needs review The PR code is done & tested, needs review labels Jun 22, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: work in progress stage: needs review The PR code is done & tested, needs review labels Aug 27, 2020
@Manuel-Suarez-Abascal
Copy link
Contributor

Manuel-Suarez-Abascal commented Dec 13, 2022 •
edited
Loading

I would like to attempt to resolve this issue. Can you please provide me with some guidance on which files are involved? We should update the labels. Instead of using pkg/server or pkg/reporter labels, we should use the pkg/driver label instead as stated in this comment. @sainthkh

Closed
3 tasks
@dr-rockso
Copy link

test

@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label May 15, 2024
@cypress-app-bot
Copy link
Collaborator

This issue has been closed due to inactivity.

@cypress-app-bot cypress-app-bot closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg/reporter This is due to an issue in the packages/reporter directory pkg/server This is due to an issue in the packages/server directory stale no activity on this issue for a long period type: bug
Projects
None yet
Milestone
No milestone
9 participants
@chrisbreiding @jennifer-shehane @bahmutov @lilaconlee @sainthkh @emilyrohrbough @dr-rockso @Manuel-Suarez-Abascal @cypress-app-bot