Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log multiple arguments passed in the click method #26432

Closed
wants to merge 22 commits into from
Closed

fix: log multiple arguments passed in the click method #26432

wants to merge 22 commits into from

Conversation

Manuel-Suarez-Abascal
Copy link
Contributor

@Manuel-Suarez-Abascal Manuel-Suarez-Abascal commented Apr 4, 2023

Additional details

N/A

Steps to test

To reproduce the current behavior, the issue provides the following test code:

it('test', () => {
  cy.visit('https://example.cypress.io/commands/actions')
  cy.get('#action-canvas').click('topRight')                // command log shows '{position: topRight}'
  cy.get('#action-canvas').click('topRight', { force: true }) // command log shows '{force: true, position: topRight}'
})

How has the user experience changed?

Now both the arguments & options get logged in Cypress's Test Runner. Check the image below for more context:

Screenshot 2023-04-11 at 12 43 14 PM

PR Tasks

@cypress
Copy link

cypress bot commented Apr 4, 2023

5 failed and 34 flaky tests on run #45270 ↗︎

5 26904 1281 0 Flakiness 34

Details:

fix: log multiple arguments passed in the click method
Project: cypress Commit: 37ccc2b19f
Status: Failed Duration: 19:38 💡
Started: Apr 4, 2023 8:29 PM Ended: Apr 4, 2023 8:49 PM
Failed  cypress/e2e/commands/actions/click.cy.js • 1 failed test • 5x-driver-electron

View Output Video

Test Artifacts
... > can specify x and/or y to be 0 Output Video
Failed  cypress/e2e/commands/actions/click.cy.js • 1 failed test • 5x-driver-firefox

View Output Video

Test Artifacts
... > can specify x and/or y to be 0 Output
Failed  cypress/e2e/commands/actions/click.cy.js • 1 failed test • 5x-driver-chrome:beta

View Output Video

Test Artifacts
... > can specify x and/or y to be 0 Output Video
Failed  cypress/e2e/commands/actions/click.cy.js • 1 failed test • 5x-driver-chrome

View Output Video

Test Artifacts
... > can specify x and/or y to be 0 Output Video
Failed  cypress/e2e/commands/actions/click.cy.js • 1 failed test • 5x-driver-webkit

View Output Video

Test Artifacts
... > can specify x and/or y to be 0 Output Video
Flakiness  create-from-component.cy.ts • 2 flaky tests • app-e2e

View Output Video

Test Artifacts
... > runs generated spec Output Screenshots Video
... > runs generated spec Output Screenshots Video
Flakiness  runner/reporter.command_errors.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
errors ui > cy.readFile Output Screenshots Video
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video
Flakiness  cypress-in-cypress-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress CT > default config > redirects to the specs list with error if a spec is not found Output Screenshots Video
Flakiness  cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution Output Screenshots Video

The first 5 flaky specs are shown, see all 21 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@nagash77 nagash77 assigned astone123 and emilyrohrbough and unassigned astone123 Apr 5, 2023
@emilyrohrbough
Copy link
Member

@Manuel-Suarez-Abascal Thank you so much for taking on this issue! We will need to add some test coverage for this to get across the line.

@mjhenkes mjhenkes assigned mjhenkes and unassigned emilyrohrbough Apr 11, 2023
@mschile mschile removed their assignment May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

command args are not displayed in the Command Log when options also passed into command
6 participants