Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert order of scheduler configure() & log_start() #5114

Merged
merged 5 commits into from
Sep 6, 2022

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Sep 2, 2022

Closes #4982, follow-up to #4836

Fix bug where a validation error on workflow startup was not being printed before daemonization (aka detach), which made it look like nothing was wrong. Also the return code was zero instead of non-zero as it should be.

This partially reverts some of the logging re-ordering from #4836

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • CHANGES.md entry included if this is a change that can affect users
  • No docs needed
  • If this is a bug fix, PRs raised to both master and the relevant maintenance branch.

@MetRonnie MetRonnie added this to the 8.0.2 milestone Sep 2, 2022
@MetRonnie MetRonnie self-assigned this Sep 2, 2022
@MetRonnie MetRonnie linked an issue Sep 2, 2022 that may be closed by this pull request
@MetRonnie MetRonnie added the bug Something is wrong :( label Sep 2, 2022
@MetRonnie MetRonnie marked this pull request as ready for review September 2, 2022 10:57
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked this out and have tested that it solves the issue and double checked the logging is still correct, thanks @MetRonnie.

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like patch_log_level

@hjoliver hjoliver merged commit 51db763 into cylc:8.0.x Sep 6, 2022
@MetRonnie MetRonnie deleted the daemon branch September 12, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid workflows fail post-detach
3 participants