Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid workflows fail post-detach #4982

Closed
oliver-sanders opened this issue Jul 14, 2022 · 1 comment · Fixed by #5114
Closed

Invalid workflows fail post-detach #4982

oliver-sanders opened this issue Jul 14, 2022 · 1 comment · Fixed by #5114
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@oliver-sanders
Copy link
Member

When [scheduler][run hosts] are used to run scheduler on, validation errors occur post-detatch which makes the failure invisible.

E.G. when you run an invalid workflow:

$ cylc play <id>
...
<id>: <server> PID=<pid>

It looks like it worked, but it didn't:

$ cylc cat-log <id>
...
ERROR - Workflow shutting down - WorkflowConfigError: This workflow requires an initial cycle point.

This didn't use to be the case, the change was likely caused by recent startup reordering.

Note: #3896 will reduce the pressure on this, however, ideally we would fix this in the cylc play command properly.

Pull requests welcome!

@oliver-sanders oliver-sanders added the could be better Not exactly a bug, but not ideal. label Jul 14, 2022
@oliver-sanders oliver-sanders added this to the cylc-8.0.1 milestone Jul 14, 2022
@oliver-sanders oliver-sanders modified the milestones: cylc-8.0.1, cylc-8.1.0 Jul 27, 2022
@MetRonnie MetRonnie changed the title invalid workflows fail post-detatch Invalid workflows fail post-detach Aug 31, 2022
@MetRonnie MetRonnie self-assigned this Aug 31, 2022
@MetRonnie
Copy link
Member

MetRonnie commented Sep 1, 2022

I have reproduced this even without [scheduler][run hosts], so maybe higher priority?

#4836 is the culprit, however I'm struggling to figure out why just by looking at the code changes. Will try more in-depth debugging...

@MetRonnie MetRonnie linked a pull request Sep 2, 2022 that will close this issue
8 tasks
@MetRonnie MetRonnie modified the milestones: cylc-8.1.0, 8.0.2 Sep 2, 2022
@MetRonnie MetRonnie added bug Something is wrong :( and removed could be better Not exactly a bug, but not ideal. labels Sep 2, 2022
@oliver-sanders oliver-sanders modified the milestones: cylc-8.0.2, cylc-8.0.3 Sep 12, 2022
@MetRonnie MetRonnie modified the milestones: cylc-8.0.3, cylc-8.0.2 Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants