Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mesh related bugs #6124

Merged
merged 3 commits into from
May 9, 2023
Merged

Fix mesh related bugs #6124

merged 3 commits into from
May 9, 2023

Conversation

BenjaminDeleze
Copy link

  • The test suite was crashing in debug mode since Fix mesh bounding object #6047. It was because we were trying to create a new ode object instead of updating the existing one, thus triggering an assert. The tricky part was to fix the issue without removing the fix from Fix mesh bounding object #6047.
  • The boundingSphere was not updated when a mesh geometry was changed.

@BenjaminDeleze BenjaminDeleze added bug Something isn't working test suite Start the test suite labels May 8, 2023
@BenjaminDeleze BenjaminDeleze added this to the R2023a-rev1 milestone May 8, 2023
@BenjaminDeleze BenjaminDeleze self-assigned this May 8, 2023
@BenjaminDeleze BenjaminDeleze added the test sources Start the sources test on all platforms label May 8, 2023
@BenjaminDeleze BenjaminDeleze marked this pull request as ready for review May 8, 2023 15:12
@BenjaminDeleze BenjaminDeleze requested a review from a team as a code owner May 8, 2023 15:12
@ygoumaz ygoumaz self-requested a review May 8, 2023 15:17
ygoumaz
ygoumaz approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@ygoumaz ygoumaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well! Thank you.

@BenjaminDeleze BenjaminDeleze merged commit 5b2ce61 into master May 9, 2023
@BenjaminDeleze BenjaminDeleze deleted the fix-test-suite branch May 9, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygoumaz ygoumaz ygoumaz approved these changes

Assignees

@BenjaminDeleze BenjaminDeleze

Labels
bug Something isn't working test sources Start the sources test on all platforms test suite Start the test suite
Milestone
R2023a-rev1
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjaminDeleze @ygoumaz