Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mesh bounding object #6047

Merged
merged 6 commits into from
Apr 11, 2023
Merged

Fix mesh bounding object #6047

merged 6 commits into from
Apr 11, 2023

Conversation

BenjaminDeleze
Copy link

@BenjaminDeleze BenjaminDeleze commented Apr 3, 2023 •
edited
Loading

Description
When using a mesh boundingObject (bad practice), the bounding object is not taken into account if the mesh url is remote and the mesh is not present in the cash because we download the mesh after creating the ode object.

Fix

  • When the object is in the world when we open it.
  • When the object is added after the initial loading.

@BenjaminDeleze BenjaminDeleze added the bug Something isn't working label Apr 3, 2023
@BenjaminDeleze BenjaminDeleze added this to the R2023a-rev1 milestone Apr 3, 2023
@BenjaminDeleze BenjaminDeleze self-assigned this Apr 3, 2023
@BenjaminDeleze BenjaminDeleze added test suite Start the test suite test sources Start the sources test on all platforms labels Apr 4, 2023
@BenjaminDeleze BenjaminDeleze changed the title Fix when object is already in the world Fix mesh bounding object Apr 5, 2023
@BenjaminDeleze BenjaminDeleze marked this pull request as ready for review April 5, 2023 05:56
@BenjaminDeleze BenjaminDeleze requested a review from a team as a code owner April 5, 2023 05:56
@BenjaminDeleze BenjaminDeleze requested a review from ygoumaz April 11, 2023 08:17
ygoumaz
ygoumaz previously approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@ygoumaz ygoumaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Is this bug present in R2023a? If yes, an entry should be added in the changelog.

@BenjaminDeleze BenjaminDeleze requested a review from ygoumaz April 11, 2023 11:48
ygoumaz
ygoumaz approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@ygoumaz ygoumaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@BenjaminDeleze BenjaminDeleze merged commit 8bdee90 into master Apr 11, 2023
@BenjaminDeleze BenjaminDeleze deleted the fix-bo-mesh-physics branch April 11, 2023 12:42
@BenjaminDeleze BenjaminDeleze mentioned this pull request May 8, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygoumaz ygoumaz ygoumaz approved these changes

Assignees

@BenjaminDeleze BenjaminDeleze

Labels
bug Something isn't working test sources Start the sources test on all platforms test suite Start the test suite
Milestone
R2023a-rev1
Development

Successfully merging this pull request may close these issues.
3 participants
@BenjaminDeleze @ygoumaz @omichel