-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for output file path / name #386
Conversation
0c77622
to
3c58283
Compare
fileTemplate, | ||
secrets, | ||
) | ||
} | ||
|
||
func (sg *SecretGroup) absoluteFilePath(secretsBasePath string) (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method SecretGroup.absoluteFilePath
has 5 return statements (exceeds 4 allowed).
d6acb31
to
0a399e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looking good. Left some comments
6961df4
to
5e21452
Compare
5e21452
to
a9a47ee
Compare
a9a47ee
to
02e7fcb
Compare
Code Climate has analyzed commit 02e7fcb and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.4% (0.3% change). View more on Code Climate. |
Note: This depends on #381
Implemented Changes
Implement validation on the annotation specifying output file path / name and make sure there are tests for the following cases:
Also ensure that if you are using a non-custom (i.e. non-templatized) file format (or using the default yaml template), and:
<secret-group-name>.<file-type>
.Connected Issue/Story
CyberArk internal issue link: ONYX-13143
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security