-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate secrets base path into secret group filepath #381
Conversation
51bb7f3
to
d203f3b
Compare
79151b0
to
425e96a
Compare
c6071f4
to
9dbacd5
Compare
Adds more unit tests for the secret group filepath behavior, adds edge case and refactors some interaction with paths
This change applies this default both at annotation parsing time and at secret fetching time.
304b6f1
to
49a5d0d
Compare
Code Climate has analyzed commit 49a5d0d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 86.7% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.1% (1.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Implemented Changes
Carried out in collaboration with @john-odonnell.
These changes were initially meant to land with the PR for Onyx-11974. They incorporate the secrets base path
/conjur/secret
onto the relative file paths for each secret group defined by annotations, and handle validations.Connected Issue/Story
CyberArk internal issue link: Onyx-11974
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security