Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates conjur-authn-k8s version to v0.19.1 #1375

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

diverdane
Copy link
Contributor

@diverdane diverdane commented Feb 4, 2021

What does this PR do?

This change updates the version of cyberark/conjur-authn-k8s-client that
is used by the Secretless Broker to v0.19.1. In this release of
cyberark/conjur-authn-k8s-client, the Authenticate and
ParseAuthenticationResponse methods were combined into a single method,
so calls to the conjur-authn-k8s-client are changed accordingly.

This change also removes a -mod=readonly flag from the macOS keychain test.
This flag was causing failures in the macOS GitHub actions test because the
macOS builds were requiring changes to go.sum, and having -mod=readonly
causes this to be an error condition.

This change also includes a run of go mod tidy to update go.mod and go.sum.

What ticket does this PR close?

Resolves #1368

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • This PR does not require updating any documentation, or
  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs

(For releases only) Manual tests

@diverdane diverdane requested a review from a team as a code owner February 4, 2021 21:13
@diverdane diverdane self-assigned this Feb 4, 2021
@diverdane diverdane changed the title WIP - Updates conjur-authn-k8s version to v0.19.1 Updates conjur-authn-k8s version to v0.19.1 Feb 8, 2021
doodlesbykumbi
doodlesbykumbi previously approved these changes Feb 9, 2021
Copy link
Contributor

@doodlesbykumbi doodlesbykumbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was thinking we might need a CHANGELOG entry for it but I doubt it since this is an altogether internal change. Needs a rebase though :(

@izgeri
Copy link
Contributor

izgeri commented Feb 9, 2021

it might be good to have a changelog message, just because we try to keep our authn-k8s client versions aligned between k8s components when we do suite or DAP releases

@diverdane diverdane force-pushed the 1368-bump-authn-k8s branch 2 times, most recently from 5782c6e to a2b5133 Compare February 10, 2021 13:29
This change updates the version of cyberark/conjur-authn-k8s-client that
is used by the Secretless Broker to v0.19.1. In this release of
cyberark/conjur-authn-k8s-client, the Authenticate and
ParseAuthenticationResponse methods were combined into a single method,
so calls to the conjur-authn-k8s-client are changed accordingly.
@codeclimate
Copy link

codeclimate bot commented Feb 10, 2021

Code Climate has analyzed commit bbaf72f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.6% (0.0% change).

View more on Code Climate.

@doodlesbykumbi doodlesbykumbi merged commit c8e2bbb into master Feb 10, 2021
@doodlesbykumbi doodlesbykumbi deleted the 1368-bump-authn-k8s branch February 10, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update conjur-authn-k8s version to v0.19.1
3 participants