Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update conjur-authn-k8s version to v0.19.1 #1368

Closed
2 tasks
izgeri opened this issue Jan 25, 2021 · 0 comments · Fixed by #1375
Closed
2 tasks

Update conjur-authn-k8s version to v0.19.1 #1368

izgeri opened this issue Jan 25, 2021 · 0 comments · Fixed by #1375
Assignees
@diverdane
Labels
component/secretless-broker kind/enhancement

Comments

@izgeri
Copy link
Contributor

izgeri commented Jan 25, 2021

Description

In the v0.19.1 release of cyberark/conjur-authn-k8s-client, the Authenticate and ParseAuthenticationResponse methods were combined into a single method.

In this card, we bump the authn-k8s client version and update the method calls.

Note that the logic that uses these methods is internally used here:

secretless-broker/internal/providers/conjur/provider.go

Line 240 in 85c481b

err = p.Authenticator.ParseAuthenticationResponse(resp)

Depends on cyberark/conjur-authn-k8s-client#210
Related to cyberark/conjur-authn-k8s-client#180

AC:

  • Bump authn-k8s client version to 0.19.1
  • Update the Conjur provider logic to remove the redundant ParseAuthenticationResponse call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diverdane diverdane

Labels
component/secretless-broker kind/enhancement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates conjur-authn-k8s version to v0.19.1 cyberark/secretless-broker
2 participants
@diverdane @izgeri