Update mssql driver to support verify-ca and verify-full #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doodlesbykumbi
changed the title
doodlesbykumbi
force-pushed
the
mssql-verify-ca
branch
3 times, most recently
from
8f460c1 to
80f61d3
Compare
doodlesbykumbi
force-pushed
the
mssql-verify-ca
branch
from
80f61d3 to
c446521
Compare
BradleyBoutcher
previously approved these changes
Apr 15, 2020
3 tasks
mssql driver only supported full verification out of the box. Custom verification logic is necessary to ignore hostname verification.
doodlesbykumbi
force-pushed
the
mssql-verify-ca
branch
from
c446521 to
369043a
Compare
|
Code Climate has analyzed commit 369043a and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 48.4% (0.1% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1165
Closes #1199
mssql driver only supported full verification out of the box, which corresponds to sslmode=verify-full.
Checklist before merge: