add disableverifyhostname parameter #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| _, err = certs[0].Verify(opts) | ||
| } | ||
|
|
There was a problem hiding this comment.
It looks like tlsConn.Handshake() can return an error before we get to line 1151. We should have error handling there as well as at the end of this if block
There was a problem hiding this comment.
There's no need. This block of conditional code is only executed if err is nil, plus the other conditions.
doodlesbykumbi
force-pushed
the
disable-verify-hostname
branch
from
a71c92c to
5e511e7
Compare
1 task
| @@ -1145,6 +1148,27 @@ initiate_connection: | |||
| passthrough := passthroughConn{c: &handshakeConn} | |||
| tlsConn := tls.Client(&passthrough, &config) | |||
| err = tlsConn.Handshake() | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
I'd just remove this extra line and it's good to go
disableverifyhostname prevents checking the hostname on tls verification. This means that only the certificate is verified.
doodlesbykumbi
force-pushed
the
disable-verify-hostname
branch
from
5e511e7 to
7eb9d7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disableverifyhostname prevents checking the hostname on tls verification. This means that only the certificate is verified.