Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CUDA version in cuda11x-cuda-python CI #8737

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

asi1024
Copy link
Member

@asi1024 asi1024 commented Nov 14, 2024

@asi1024
Copy link
Member Author

asi1024 commented Nov 14, 2024

/test cuda11x-cuda-python

@asi1024
Copy link
Member Author

asi1024 commented Nov 14, 2024

@leofang leofang mentioned this pull request Nov 14, 2024
@asi1024
Copy link
Member Author

asi1024 commented Nov 14, 2024

@asi1024 asi1024 added cat:enhancement Improvements to existing features to-be-backported Pull-requests to be backported to stable branch prio:medium labels Nov 14, 2024
kmaehashi
kmaehashi previously approved these changes Nov 14, 2024
Copy link
Member

@kmaehashi kmaehashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! Please proceed to merge and backport after test pass.

@kmaehashi kmaehashi added this to the v14.0.0a1 milestone Nov 14, 2024
@@ -111,8 +111,9 @@ def __init__(self, *, full=True):
# CUDA Driver
self.cuda_build_version = str(cupy.cuda.driver.get_build_version())
if cupy.cuda.driver._is_cuda_python():
import cuda
self.cuda_build_version += f' (CUDA Python: {cuda.__version__})'
import cuda.bindings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need a try-except here. This only works if users are using latest cuda-python 11.8.5 or 12.6.2. Older versions don't have this new module yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed in 8e7203b.

@asi1024
Copy link
Member Author

asi1024 commented Nov 14, 2024

/test cuda-python

Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@asi1024 asi1024 merged commit 8e4eac9 into cupy:main Nov 14, 2024
64 checks passed
@chainer-ci
Copy link
Member

@asi1024 Failed to backport automatically.


Not cleanly cherry-picked

@asi1024 asi1024 deleted the cuda-python-ci branch November 14, 2024 23:08
asi1024 added a commit to asi1024/cupy that referenced this pull request Nov 14, 2024
Bump CUDA version in cuda11x-cuda-python CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement Improvements to existing features prio:medium to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants