Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java: include stacktrace in Convertor.toMessage(Throwable) #213

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Mar 23, 2024

🤔 What's changed?

Includes the stack trace in exception messages when using the convertor.

⚡️ What's your motivation?

Use it in the message based xml and html formatters (cucumber/junit-xml-formatter#30, cucumber/cucumber-jvm#2862).

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje force-pushed the include-stack-trace-with-converter branch 3 times, most recently from 1be8abf to 9934a96 Compare March 23, 2024 17:16
@mpkorstanje mpkorstanje force-pushed the include-stack-trace-with-converter branch from 9934a96 to b4c83aa Compare March 23, 2024 18:05
@mpkorstanje mpkorstanje marked this pull request as ready for review March 23, 2024 18:07
@mpkorstanje mpkorstanje merged commit 266aa3e into main Mar 23, 2024
27 checks passed
@mpkorstanje mpkorstanje deleted the include-stack-trace-with-converter branch March 23, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant