[Core] Include stack traces in html report #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
mpkorstanje
force-pushed
the
include-stack-trace
branch
3 times, most recently
from
1200c25 to
882ea4a
Compare
With cucumber/react-components#345 the html formatter started to support rendering stack traces. Unfortunately this also broke the regular rendering of stacktrace. And fixing this required including the stack trace the xml report as well so that when the Convertor in messages was fixed to always include the stacktrace, we wouldn't render the stacktrace in the xml formatter twice.
mpkorstanje
force-pushed
the
include-stack-trace
branch
from
882ea4a to
37a7596
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2862 +/- ##
============================================
- Coverage 84.99% 84.99% -0.01%
+ Complexity 2734 2733 -1
============================================
Files 331 331
Lines 9559 9555 -4
Branches 918 918
============================================
- Hits 8125 8121 -4
Misses 1109 1109
Partials 325 325 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Before
After
Depends on cucumber/messages#213
Depends on cucumber/junit-xml-formatter#30
⚡️ What's your motivation?
With cucumber/react-components#345 the html formatter started to support rendering stack traces. Unfortunately this also broke the regular rendering of stacktrace. And fixing this required including the stack trace the xml report aswell so that when the
Convertorin messages was fixed to always include the stacktrace, we wouldn't render the stacktrace in the xml formatter twice.🏷️ What kind of change is this?
📋 Checklist: