Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests so they pass in Rails 4 and updated gemspec. #247

Merged
merged 6 commits into from
Apr 2, 2013

Conversation

davebrace
Copy link
Contributor

In the attached commits, I updated the features that were failing against Rails 4 and ensured that the tests also passed against Rails 3.2 still. Unfortunately, I wasn't able to run the Rails 3.0 and 3.1 tests via appraisal yet because of some dependency issues, but I believe they should work as well.

In the gemspec, I updated the dependency on Rails to be '>= 3.0' and database_cleaner needs to be greater than 1.0.0.RC1 for Rails 4 support.

This should resolve #244.

@Kosmas
Copy link
Member

Kosmas commented Apr 2, 2013

@davebrace thanks.

It seems there is an error in your last commit as the Travis build cannot complete due to an error.
Can you please have a look.

@davebrace
Copy link
Contributor Author

Yeah, I'll dig in when I have a chance one night this week.

… a patched version of database_cleaner is released. I had to tweak database_cleaner for Rails 4, the changes were merged but there hasn't been a new release yet.
Kosmas added a commit that referenced this pull request Apr 2, 2013
Kosmas added a commit that referenced this pull request Apr 2, 2013
@Kosmas Kosmas merged commit ce58a00 into cucumber:master Apr 2, 2013
@Kosmas
Copy link
Member

Kosmas commented Apr 2, 2013

Tests pass on local for all rails gemfiles but fail on Travis.

@davebrace
Copy link
Contributor Author

Yeah, I was surprised when they failed on Travis because they were passing for me locally, for the rails 3_2 and rails 4_0 appraisals.

@Kosmas
Copy link
Member

Kosmas commented Apr 4, 2013

@davebrace can you please create your own branch on github with your changes, and if we can manage to get through the travis build we can try again to merge it with the master branch?
So just clone the master into your own branch and add a travis.yml file to it.
Thanks

@davebrace
Copy link
Contributor Author

@Kosmas

Sure. I only have read-only access on this repo though, so I'll need you to create the branch and then I can open a new pull request into that branch. Want to create a rails-4.0 branch?

@Kosmas
Copy link
Member

Kosmas commented Apr 4, 2013

@davebrace We do not need to create it in rails-4 branch at the moment. You can fork the current master into your own fork, modify the travis.yml to run your own branch, make it pass the build, and then if everything works ok we merge it with the master branch.

@davebrace
Copy link
Contributor Author

@Kosmas Ah, that makes sense. I'll give it a try.

@davebrace
Copy link
Contributor Author

@Kosmas I got travis running against my fork: https://github.com/davebrace/cucumber-rails

I'm pretty sure the issues are around dependency management with the older versions of rails. This weekend I'll take a look and see if I can get it all sorted out.

@Kosmas
Copy link
Member

Kosmas commented Apr 4, 2013

@davebrace That's great Dave. Thanks.

You may want to remove the notifications sent to cukes groups from the travis file ;-)

@davebrace
Copy link
Contributor Author

@Kosmas The issue appears to be that in many of the features a rails app is generated to test against, such as the mongoid features. However, when these child apps are generated, they are not respecting the gem versions specified by the appraisals configuration.

To get this to work, we'll either have to make the generated apps use appraisals gem versions. I'm not sure how to go about this yet. Any thoughts?

@Kosmas
Copy link
Member

Kosmas commented Apr 10, 2013

@davebrace Yes I think you are right. Had the same problem last time I've tried and as soon as you include the rails 4 gemfiles, the rails 3 tests are trying to install some of the rails 4 gems. Maybe is a problem that can be solved with looking at the dependencies.
Looking at using appraisal gems in the generated apps I think it would be complicated. If there is no way to resolve the dependencies, we will need to create a rails 4 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gemspec in 1.3.1 doesn't allow usage with rails 4
2 participants