Gemspec in 1.3.1 doesn't allow usage with rails 4

[fschwahn]

Hi,
I just wanted to update to 1.3.1 to get rid of the ActionController::Integration-deprecation warnings, but it won't work. I see that you added rails as a runtime dependency to the gemspec (which makes sense), but it is defined as

s.add_runtime_dependency('rails', '~> 3.0')

Could you relax it to

s.add_runtime_dependency('rails', '>= 3.0')

or

s.add_runtime_dependency('rails', '>= 3.0', '< 4.1')

or something similar? That would make it possible to use that version with rails 4.

Best regards,
Fabian

[Kosmas]

Thanks Fabian,

@aslakhellesoy @mattwynne should we try to see if it is possible to support both rails 3 and 4 in the same master branch, or make a different branch for rails 4 as suggested before?

[mattwynne]

On 21 Mar 2013, at 09:25, Kosmas Chatzimichalis [email protected] wrote:

@aslakhellesoy @mattwynne should we try to see if it is possible to support both rails 3 and 4 in the same master branch, or make a different branch for rails 4 as suggested before?

I think it's easier to comprehend if we can use the same code for both versions of Rails.

@alindeman how do you manage this in rspec-rails?

[fschwahn]

I'm already using cucumber-rails 1.3.0 with rails 4 and haven't run into any issues so far, besides the deprecation warnings. I'm using database_cleaner 1.0.0.RC1, which claims to be compatible with rails 4.
It is only a small project, but it seems capybara-rails is already somewhat compatible with rails 4.

[alindeman]

I just said >= 3.0 for now: https://github.com/rspec/rspec-rails/blob/0fec2a259b59f9de2b9aa98ced280b10ca259003/rspec-rails.gemspec#L24-L26

[Kosmas]

I just tried to put the dependency to rails >= 3.0 and use the appraisal with rails 4 gems but 17 out of the 20 tests fail. Will have a closer look.

@alindeman thanks. Is there a reason that you have activesupport,actonpack and railties separated instead of rails?

[localhots]

This is an issue for me also, it was working fine with rails 4 and cucumber-rails 1.3.0

[Kosmas]

There is a branch called master_rails4_test that is set up to make the current master version work with rails 4 and rails 3, by using the appraisal created gemfiles.
At the moment most of the tests are passing (some of them are commented out), for the rails 3 but failing for rails 4.
The plan is to make the tests pass for all versions in that branch and if everything works to merge it back to the master branch.

Anyone wishing to help with this please make a pull request in that branch (master_rails4_test).

[miketheman]

rails 4 has been released, any news on merging this branch to master and releasing a gem compatible with both?

[Kosmas]

Hi @miketheman there is a discussion here about the current issues to get the gem working with rails 4:

https://groups.google.com/forum/?fromgroups=#!topic/cukes-devs/FGXiTvf1vkg

[miketheman]

@Kosmas thanks for the link. From the thread, it looks like thing are going ok?

[greg606]

Any progress?

[Kosmas]

Hi @greg606 the progress is in the latest travis build here: https://travis-ci.org/cucumber/cucumber-rails

As you can see the rails 4 tests are failing.

[scriptfans]

Very concerned about it，Looking forward someone can solve this problem.

[Kosmas]

version 1.4.0 is rails 4 compatible now.