-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cucumber rails2 v0.3.3 #213
Conversation
w/ assist from @botandrose Should be working correctly on Capybara 0.3.9 as well. Conflicts: lib/cucumber/rails/capybara_javascript_emulation.rb
Conflicts: lib/cucumber/rails/capybara/javascript_emulation.rb
BTW, shouldn't the runtime dependency for capybara be added? |
Oh, there's already a pull request for this #200. But my fix is more complete and clean, IMHO. |
I've tried this with a fairly well covered legacy app and it worked correctly, including capybara javascript emulation for rack-test and rails delete links. Good work! gems:
|
@aslakhellesoy Can you please comment on this pull request? Do you think it would be possible to make this into 0.3.3 release? |
I've published it to RubyGems https://rubygems.org/gems/cucumber-rails2 |
@aslakhellesoy Any chance that you'll accept this? I'm having problems as well. And, as in https://github.com/cucumber/cucumber/wiki/Ruby-on-Rails the suggested versions are: gem "capybara", "1.1.1" gem "cucumber", "1.1.0" gem "cucumber-rails", "0.3.2" I would expect more people to have problems with this. Those versions are incompatible without this patch. |
as a temporary workaround try
|
Works great - many thanks! |
Do we need to create different maintenance branches now that we are using appraisal? |
I think so. This patch is not designed to work on anything above Rails 2. We don't need this stuff in the main codebase. |
@Vanuan would you like to submit your pull request against the new rails-2.3.x branch? |
see #242 |
This enables support for capybara 1.1.x and rails 2.3. I'm still forced to use rails 2 :(.
This is not intended for master. It's based on v0.3.2. Don't know how to pull request into a separate branch.
This is a backport of #130 and 68044f4, and a fix for #110