Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber rails2 v0.3.3 #213

Closed
wants to merge 3 commits into from
Closed

Cucumber rails2 v0.3.3 #213

wants to merge 3 commits into from

Conversation

Vanuan
Copy link

@Vanuan Vanuan commented May 16, 2012

This enables support for capybara 1.1.x and rails 2.3. I'm still forced to use rails 2 :(.
This is not intended for master. It's based on v0.3.2. Don't know how to pull request into a separate branch.
This is a backport of #130 and 68044f4, and a fix for #110

jfelchner and others added 3 commits May 16, 2012 21:16
w/ assist from @botandrose

Should be working correctly on Capybara 0.3.9 as well.
Conflicts:

	lib/cucumber/rails/capybara_javascript_emulation.rb
Conflicts:

	lib/cucumber/rails/capybara/javascript_emulation.rb
@Vanuan
Copy link
Author

Vanuan commented May 16, 2012

BTW, shouldn't the runtime dependency for capybara be added?

@Vanuan
Copy link
Author

Vanuan commented May 16, 2012

Oh, there's already a pull request for this #200. But my fix is more complete and clean, IMHO.

@nruth
Copy link
Contributor

nruth commented May 17, 2012

I've tried this with a fairly well covered legacy app and it worked correctly, including capybara javascript emulation for rack-test and rails delete links. Good work!

gems:

  gem 'rails', '2.3.14'
  gem 'cucumber-rails', :git => "https://github.com/Vanuan/cucumber-rails.git", :branch => "cucumber-rails2_v0.3.3"
  gem 'cucumber', '1.1.9', :require => false
  gem 'database_cleaner', '0.7.2'
  gem 'capybara', '1.1.1', :require => false
  gem 'launchy' #save_and_open_page
  gem 'rspec-rails', '1.3.4', :require => false
  gem 'rspec', '1.3.2', :require => false

@Vanuan
Copy link
Author

Vanuan commented May 31, 2012

@aslakhellesoy Can you please comment on this pull request? Do you think it would be possible to make this into 0.3.3 release?
Or I'll have to setup a fork on RubyGems?

@Vanuan
Copy link
Author

Vanuan commented May 31, 2012

I've published it to RubyGems https://rubygems.org/gems/cucumber-rails2
I'll remove it when/if v0.3.3 is released.

@vitorbaptista
Copy link

@aslakhellesoy Any chance that you'll accept this? I'm having problems as well. And, as in https://github.com/cucumber/cucumber/wiki/Ruby-on-Rails the suggested versions are:

gem "capybara", "1.1.1"
gem "cucumber", "1.1.0"
gem "cucumber-rails", "0.3.2"

I would expect more people to have problems with this. Those versions are incompatible without this patch.

@Vanuan
Copy link
Author

Vanuan commented Aug 10, 2012

as a temporary workaround try

gem "cucumber-rails2", "~> 0.3.5"

@robd
Copy link

robd commented Aug 27, 2012

Works great - many thanks!

@aslakhellesoy
Copy link
Contributor

LGTM, @Kosmas is the new maintainer of cucumber-rails. This would have to be applied against a new maintenance branch we have to create. See #238.

@Kosmas
Copy link
Member

Kosmas commented Mar 4, 2013

Do we need to create different maintenance branches now that we are using appraisal?

@mattwynne
Copy link
Member

I think so. This patch is not designed to work on anything above Rails 2. We don't need this stuff in the main codebase.

@Kosmas
Copy link
Member

Kosmas commented Mar 13, 2013

@Vanuan would you like to submit your pull request against the new rails-2.3.x branch?
We could then release cucumber-rails2 as the official gem, if you don't mind.
Thanks

@Vanuan
Copy link
Author

Vanuan commented Mar 13, 2013

see #242

@Vanuan Vanuan closed this Mar 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants