-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a maintenance branch for each major Rails version we want to support. #238
Comments
Just checking in here following the discussion in #237 about testing against multiple gemfiles - looks like the appraisal/multi-gemfile approach could definitely help here, too. And again, I'm happy to submit a PR once I get a better idea what you're after. With the branching approach, how do you envisage managing releases from the different branches? E.g. if #213 were applied to the rails-2.3.x branch, would that then be released as a discrete version of the cucumber-rails gem? Or would you expect users wanting ongoing support of old rails versions to use those specific branches as a git dependency in their Gemfiles? |
by checking the branch out locally and then run
Ideally yes. According to our wiki the latest rails-2 compatible release is cucumber-rails-0.3.2, so a new release for rails-2 should be cucumber-rails-0.3.2.1. To recap: Rails 2Development happens on the Rails 3 and Rails 4If we can make Cucumber-Rails' tests work with both Rails 3 and 4 from the master branch we don't need a separate branch. If this turns out to be a problem in the future we'll create a |
Ah right, I follow - thanks. Will get to work on a PR on master to test against rails 3.x and 4. |
The test suite now runs (and passes!) against the latest versions of: * Rails 3.0, 3.1 and 3.2 * Capybara 1.1 and 2.0 The default test task is unchanged, and runs only against Rails 3.2. See the README for details of running all (or selected) tests. Addresses issues cucumber#237 and cucumber#238.
Created new branch rails-2.3.x based on release 0.3.2 |
Since we are going to use this branch for rails 2.3.x should we remove the references to rails 3? |
@Kosmas in both comments and code? That sounds wise. |
@aslakhellesoy I was thinking about the comments and documentation initially, but yes eventually in code would make sense too. |
Closing as we have versions all versions working now. |
Currently that means:
Once Rails 4 is released, we should have those branches:
For example, PR #213 should be applied against the rails-2.3.x branch.
The text was updated successfully, but these errors were encountered: