-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename library to ci-environment #34
Conversation
@aslakhellesoy I would suggest to "Use an array to define ci environments" in a distinctive PR as it also impacts ruby and java implementation. That way, this PR, and a new one dedicated to using an array to define the CI environments would be easier to review |
I'm pretty deep into this - I think that would be too much to back out of now. We have good acceptance tests, so I'm not worried that switching to an array will break anything. This PR will also be a general cleanup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rake task to copy the json file should not be removed.
We can still want to execute rspec tests without using rake, so having it in the helper and required in the .rspec file would remain helpful
Also publishing the gem do not use rake, so executing the task just before publishing it is also required to be sure we release the same thing that what was tested before
This is a fix for #33. Summary of changes (I ended up doing some cleanup as well)
messages
CiEnvironment
Hash
with symbol keys to representCiEnvironment
ciDict.json
toCiEnvironments.json
and make it an arrayfile
task to copyCiEnvironments.json
(and remove the github action task and rspec helper that did it)