Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename library to ci-environment #34

Merged
merged 14 commits into from
Dec 8, 2021
Merged

Rename library to ci-environment #34

merged 14 commits into from
Dec 8, 2021

Conversation

aslakhellesoy
Copy link
Contributor

@aslakhellesoy aslakhellesoy commented Dec 8, 2021

This is a fix for #33. Summary of changes (I ended up doing some cleanup as well)

  • No more dependency on messages
  • Java: Use an interface for CiEnvironment
  • Ruby: Use a Hash with symbol keys to represent CiEnvironment
  • Rename ciDict.json to CiEnvironments.json and make it an array
  • Rake: use a file task to copy CiEnvironments.json (and remove the github action task and rspec helper that did it)
  • Update docs
  • Rename package and module names
  • Deleted some obsolete files

@aurelien-reeves
Copy link
Contributor

@aslakhellesoy I would suggest to "Use an array to define ci environments" in a distinctive PR as it also impacts ruby and java implementation.

That way, this PR, and a new one dedicated to using an array to define the CI environments would be easier to review

@aslakhellesoy
Copy link
Contributor Author

I'm pretty deep into this - I think that would be too much to back out of now. We have good acceptance tests, so I'm not worried that switching to an array will break anything. This PR will also be a general cleanup.

@aslakhellesoy aslakhellesoy changed the title NPM: Remove depencency on messages Rename library to ci-environment Dec 8, 2021
@aslakhellesoy aslakhellesoy marked this pull request as ready for review December 8, 2021 12:25
Copy link
Contributor

@aurelien-reeves aurelien-reeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rake task to copy the json file should not be removed.
We can still want to execute rspec tests without using rake, so having it in the helper and required in the .rspec file would remain helpful
Also publishing the gem do not use rake, so executing the task just before publishing it is also required to be sure we release the same thing that what was tested before

.github/workflows/release-ruby.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants