Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename this repo/library to ci-environment #33

Closed
aslakhellesoy opened this issue Dec 8, 2021 · 1 comment
Closed

Rename this repo/library to ci-environment #33

aslakhellesoy opened this issue Dec 8, 2021 · 1 comment
Assignees

Comments

@aslakhellesoy
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I am building a library that needs the CI detection logic in this library, but it doesn't need the messages dependency.

Describe the solution you'd like

  • Rename this repo to cucumber/ci-environment
  • Rename this library to:
    • NPM: @cucumber/ci-environment
    • Gems/Ruby: cucumber-ci-environment / Cucumber::CiEnvironment
    • Maven/Java: io.cucumber:ci-environment / io.cucumber.cienvironment
  • Remove messages dependency and return a custom CiEnvironment class/struct instead

Describe alternatives you've considered
I considered using the library as-is, but given the size of messages it seems unnecessary bloat

Additional context
Cucumber implementations that currently depend on create-meta should be upgraded to depend on the new library, and create the Meta message from the CiEnvironment object returned by this library.

@aslakhellesoy
Copy link
Contributor Author

Fixed by #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant