Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include private domains #28

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Include private domains #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c82e1f
Include private domains
fupduck Jun 20, 2024
40fd0d7
Merge branch 'main' into private_zones
fupduck Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion certbot_dns_hetzner/dns_hetzner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@

@staticmethod
def _get_zone(domain):
zone_name = tldextract.extract(domain)
extract = tldextract.TLDExtract()
zone_name = extract(domain, include_psl_private_domains=True)

Check warning on line 48 in certbot_dns_hetzner/dns_hetzner.py

View check run for this annotation

Codecov / codecov/patch

certbot_dns_hetzner/dns_hetzner.py#L47-L48 

Added lines #L47 - L48 were not covered by tests
return '.'.join([zone_name.domain, zone_name.suffix])

def _perform(self, domain, validation_name, validation):
Expand Down
Loading