Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include private domains #28

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Include private domains #28

merged 2 commits into from
Jun 20, 2024

Conversation

fupduck
Copy link
Contributor

@fupduck fupduck commented Jun 20, 2024

In issue 24 problems regarding private tlds were mentioned.

To fix this I now include them. I did not see a reason to not change this.

@fupduck fupduck requested a review from l0rn June 20, 2024 16:09
@fupduck fupduck marked this pull request as ready for review June 20, 2024 16:17
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.50%. Comparing base (d01d568) to head (40fd0d7).

Files Patch % Lines
certbot_dns_hetzner/dns_hetzner.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   89.36%   87.50%   -1.87%     
==========================================
  Files           2        2              
  Lines          47       48       +1     
==========================================
  Hits           42       42              
- Misses          5        6       +1     
Flag Coverage Δ
unittests 87.50% <0.00%> (-1.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fupduck fupduck merged commit 8d28a58 into main Jun 20, 2024
8 of 9 checks passed
@fupduck fupduck deleted the private_zones branch June 20, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant