fix(spec): change membership dates to ensure user is almost archived #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidojw
changed the title
wilco375
approved these changes
Feb 14, 2022
|
Also noticed this test randomly seems to fail once in a while. Nice fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The UserCleanupJob will see users as "almost archived" when their last membership is
< 18 months.ago,user_cleanup_job_spec.rbcreates a membership that ended exactly 18 months ago and thus the job at random occasions doesn't find that the user will almost be archived. This PR changes the end_date to one month earlier so that the job certainly succeeds.Found out about this in #277 and saw that this test is also failing in #278.