feat: GitHub Actions #277
Merged
feat: GitHub Actions #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/continuous-integration.yml
This was referenced Feb 14, 2022
wilco375
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This project's equivalent of csvalpha/amber-ui#377!
There's a small con with GitHub Actions in this project: workflow runs on PRs from forked repositories do not get access to the repository's secrets (
RAILS_MASTER_KEY, because this can be a vulnerability), and thus some tests that depend on having these will fail (mail_alias_sync_job_spec.rbandmarkdown_helper_spec.rb). Maybe in the future we can wind up a temporary camo container just for testing to not need the production secret for that anymore, but for the ImprovMX secret I cannot think of a good solution.Because of above reason, this PR's workflows also fail 😅
Related: https://github.com/csvalpha/ELISA/issues/13