Built-in customizable deposit WASM #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avi-D-coder
approved these changes
Jul 24, 2024
Comment on lines
+7
to
+19
| let session_binaries_dir = env::var("PATH_TO_SESSION_BINARIES") | ||
| .expect("PATH_TO_SESSION_BINARIES environment variable is not set"); | ||
|
|
||
| // Get the output directory set by Cargo. | ||
| let out_dir = env::var("OUT_DIR").expect("OUT_DIR not set"); | ||
| let source_path = Path::new(&session_binaries_dir).join("deposit-session-optimized.wasm"); | ||
| let dest_path = Path::new(&out_dir).join("deposit-session-optimized.wasm"); | ||
|
|
||
| // Copy the file from the source to the destination | ||
| fs::copy(&source_path, dest_path).expect("Failed to copy WASM file"); | ||
|
|
||
| // Print out a message to re-run this script if the source file changes. | ||
| println!("cargo:rerun-if-changed={}", source_path.display()); |
There was a problem hiding this comment.
NIT: This works, but I am not clear why we need to copy the wasm into OUT_DIR. Why not just include_bytes from PATH_TO_SESSION_BINARIES directly?
There was a problem hiding this comment.
include_bytes!(env!("PATH_TO_SESSION_BINARIES")) would work too. However, I would like to extend build script to automatically discover and optimize WASMs (similar to this) so PATH_TO_SESSION_BINARIES can be avoided.
The whole project works great in Nix, but being able to just cargo build without bunch of extra env setup would be better.
marijanp
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159 by:
PATH_TO_SESSION_BINARIES