-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Automatic WASM discovery and optimization #164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be used for automatic WASM optimization.
`PATH_TO_SESSION_BINARIES` no longer needs to be set :).
koxu1996
commented
Jul 25, 2024
we could build the session code for the user instead of telling them how too. if the env is not set print the rerun if changed directive on the session code dir and then run the cargo build. make sure to use https://doc.rust-lang.org/cargo/reference/build-scripts.html#rerun-if-env-changed on the env too |
@Avi-D-coder Done in d5fd874. |
Avi-D-coder
approved these changes
Jul 31, 2024
marijanp
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces automatic session code discovery (and optimization), based on project structure - fix for #163. See how it works now:
No need to set
PATH_TO_SESSION_BINARIES
or runwasm-opt
😌.In case user didn't compiled session code, he will be instructed to do it:
NOTE:
PATH_TO_SESSION_BINARIES
still can be set.