replication: remove annotation from pvc #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
nixpanic,
Rakshith-R,
yati1998 and
Yuggupta27
Madhu-1
force-pushed
the
support-owner-ant-del
branch
from
537792d to
472f351
Compare
As part of csi-addons#213 support was added to have one VR per PVC, once the VR is deleted we need to remove the annotation so new VR can be created for the same PVC. This PR adds the missing piece. Signed-off-by: Madhu Rajanna <[email protected]>
the owner reference should be added only when the VR is created not always, moved adding annotatePVCWithOwner to the correct if check. Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
force-pushed
the
support-owner-ant-del
branch
from
472f351 to
2e307ad
Compare
Rakshith-R
approved these changes
Aug 25, 2022
nixpanic
approved these changes
Aug 25, 2022
Nikhil-Ladha
pushed a commit
to Nikhil-Ladha/kubernetes-csi-addons
that referenced
this pull request
Oct 25, 2024
Syncing latest changes from upstream main for kubernetes-csi-addons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #213, support was added to have one VR per PVC. Once the VR is deleted, we need to remove the annotation so a new VR can be created for the same PVC. This PR adds the missing piece.
Signed-off-by: Madhu Rajanna [email protected]