Ensure only one VR per PVC #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
nixpanic,
Rakshith-R,
yati1998 and
Yuggupta27
Rakshith-R
requested changes
Aug 25, 2022
VolumeReplication should ensure there is only one VR per PVC, as otherwise it can lead to orchestrating the PVC based on multiple VRs to an inconsistent state. With this Patch only one VR will operator on a single PVC. Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
force-pushed
the
block-multiple-vr
branch
from
1e05d97 to
1fe592d
Compare
nixpanic
approved these changes
Aug 25, 2022
Madhu-1
added a commit
to Madhu-1/kubernetes-csi-addons
that referenced
this pull request
Aug 25, 2022
As part of csi-addons#213 support was added to have one VR per PVC, once the VR is deleted we need to remove the annotation so new VR can be created for the same PVC. This PR adds the missing piece. Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
added a commit
to Madhu-1/kubernetes-csi-addons
that referenced
this pull request
Aug 25, 2022
As part of csi-addons#213 support was added to have one VR per PVC, once the VR is deleted we need to remove the annotation so new VR can be created for the same PVC. This PR adds the missing piece. Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
added a commit
to Madhu-1/kubernetes-csi-addons
that referenced
this pull request
Aug 25, 2022
As part of csi-addons#213 support was added to have one VR per PVC, once the VR is deleted we need to remove the annotation so new VR can be created for the same PVC. This PR adds the missing piece. Signed-off-by: Madhu Rajanna <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
As part of #213 support was added to have one VR per PVC, once the VR is deleted we need to remove the annotation so new VR can be created for the same PVC. This PR adds the missing piece. Signed-off-by: Madhu Rajanna <[email protected]>
| ownerName := pvc.ObjectMeta.Annotations[replicationv1alpha1.VolumeReplicationNameAnnotation] | ||
| if ownerName == "" { | ||
| pvc.ObjectMeta.Annotations[replicationv1alpha1.VolumeReplicationNameAnnotation] = req.Name | ||
| err := r.Update(ctx, pvc) |
There was a problem hiding this comment.
2 separate VR reconciles could update the annotation at the same time. (2 go routines etc.). This may need some rudimentary locking such that there is only one updater (fetch and update sequence) for a given PVC.
This should be quite rare, but something to keep track of.
There was a problem hiding this comment.
Agree but am thinking if 2 VR acts on the same PVC to add annotation, either one will fail and one will pass and should be fine. what do you think? as its a quite rare condition we can see how to fix it.
openshift-cherrypick-robot
referenced
this pull request
in openshift-cherrypick-robot/kubernetes-csi-addons
Aug 30, 2022
As part of red-hat-storage#213 support was added to have one VR per PVC, once the VR is deleted we need to remove the annotation so new VR can be created for the same PVC. This PR adds the missing piece. Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
pushed a commit
to Madhu-1/kubernetes-csi-addons
that referenced
this pull request
Nov 27, 2024
Syncing latest changes from main for kubernetes-csi-addons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VolumeReplication should ensure there is only one VR per PVC, as otherwise, it can lead to orchestrating the
PVC is based on multiple VRs to an inconsistent state. With this Patch only one VR will operate on a single PVC.
Signed-off-by: Madhu Rajanna [email protected]