Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers: Use ISO 8601 timestamp format in logs #211

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented Aug 23, 2022

Use ISO 8601 for better timestamp readability from logs.

we can also use kubectl logs --timestamps=true options for the timestamp.

Ref: RamenDR/ramen#499

fixes #198

without fix

./bin/manager
1.6612317914296057e+09	INFO	controller-runtime.metrics	Metrics server is starting to listen	{"addr": ":8080"}
I0823 10:46:32.570418 1458419 request.go:601] Waited for 1.049527477s due to client-side throttling, not priority and fairness, request: GET:https://192.168.39.26:8443/apis/policy/v1?timeout=32s
1.661231793128033e+09	ERROR	setup	unable to create controller	{"controller": "ReclaimSpaceCronJob", "error": "no matches for kind \"ReclaimSpaceJob\" in version \"csiaddons.openshift.io/v1alpha1\""}
main.main
	/home/mrajanna/workspace/src/github.com/csi-addons/kubernetes-csi-addons/cmd/manager/main.go:130
runtime.main
	/usr/local/go/src/runtime/proc.go:250

with this Fix

./bin/manager
2022-08-23T10:48:39.306+0530	INFO	controller-runtime.metrics	Metrics server is starting to listen	{"addr": ":8080"}
I0823 10:48:40.454459 1460747 request.go:601] Waited for 1.04569822s due to client-side throttling, not priority and fairness, request: GET:https://192.168.39.26:8443/apis/autoscaling/v2beta2?timeout=32s
2022-08-23T10:48:41.006+0530	ERROR	setup	unable to create controller	{"controller": "ReclaimSpaceCronJob", "error": "no matches for kind \"ReclaimSpaceJob\" in version \"csiaddons.openshift.io/v1alpha1\""}
main.main
	/home/mrajanna/workspace/src/github.com/csi-addons/kubernetes-csi-addons/cmd/manager/main.go:132
runtime.main
	/usr/local/go/src/runtime/proc.go:250

Signed-off-by: Madhu Rajanna [email protected]

@mergify mergify bot requested a review from Yuggupta27 August 23, 2022 05:24
@Rakshith-R
Copy link
Member

@Madhu-1 need to run go mod vendor

@Madhu-1
Copy link
Member Author

Madhu-1 commented Aug 23, 2022

Missed adding go.mod file should be good now.

Use ISO 8601 for better timestamp redability
from logs.

we can also use kubectl logs --timestamps=true
options for timestamp.

Ref: RamenDR/ramen#499

Signed-off-by: Madhu Rajanna <[email protected]>
@mergify mergify bot merged commit a04f2cc into csi-addons:main Aug 23, 2022
Nikhil-Ladha pushed a commit to Nikhil-Ladha/kubernetes-csi-addons that referenced this pull request Oct 25, 2024
[DOWNSTREAM-ONLY] add ocs default toleration to controller podspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide readable timestamps in the logs
3 participants