Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide readable timestamps in the logs #198

Closed
nixpanic opened this issue Aug 1, 2022 · 0 comments · Fixed by #211
Closed

Provide readable timestamps in the logs #198

nixpanic opened this issue Aug 1, 2022 · 0 comments · Fixed by #211

Comments

@nixpanic
Copy link
Collaborator

nixpanic commented Aug 1, 2022

Times of log messages are in a format that is difficult to read format:

1.6593560518327549e+09	INFO	Making controller reclaim space request	{"controller": "reclaimspacejob", "controllerGroup": "csiaddons.openshift.io", "controllerKind": "ReclaimSpaceJob", "reclaimSpaceJob": {"name":"sample-1","namespace":"default"}, "namespace": "default", "name": "sample-1", "reconcileID": "dc87e88f-318a-40be-a87b-63151495d4d3", "PVCName": "rbd-pvc", "PVCNamespace": "default", "PVName": "pvc-82801af6-dccb-4323-a08c-743766b74028", "NodeID": "ip-10-0-149-143.ec2.internal", "nodeClient": "rook-ceph/csi-rbdplugin-4z2wj", "controllerClient": "rook-ceph/csi-rbdplugin-provisioner-5794db6555-npwr7"}
1.6593560520878572e+09	INFO	Successfully completed reclaim space operation	{"controller": "reclaimspacejob", "controllerGroup": "csiaddons.openshift.io", "controllerKind": "ReclaimSpaceJob", "reclaimSpaceJob": {"name":"sample-1","namespace":"default"}, "namespace": "default", "name": "sample-1", "reconcileID": "dc87e88f-318a-40be-a87b-63151495d4d3", "PVCName": "rbd-pvc", "PVCNamespace": "default", "PVName": "pvc-82801af6-dccb-4323-a08c-743766b74028", "NodeID": "ip-10-0-149-143.ec2.internal", "nodeClient": "rook-ceph/csi-rbdplugin-4z2wj", "controllerClient": "rook-ceph/csi-rbdplugin-provisioner-5794db6555-npwr7"}

It is not easy compare times with other logs, the current situation is very user unfriendly.

@mergify mergify bot closed this as completed in #211 Aug 23, 2022
Rakshith-R pushed a commit to Rakshith-R/kubernetes-csi-addons that referenced this issue Sep 24, 2024
…rry-pick-197-to-release-4.17

BUG 2303822: [release-4.17] bundle: Update CSV capability to Seamless Upgrades
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant