Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Libraries - Update react-select to 5.10.0 #357

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

rmanganiello
Copy link

@rmanganiello rmanganiello commented Jan 24, 2025

This PR is meant to be applied in v5 branch

This PR updates the react-select dependency to the latest version which is fully compatible with React 19.

It also solves issue #356

Reference: https://github.com/JedWatson/react-select/releases

This PR updates the `react-select` dependency to the latest version
which is fully compatible with React 19.

It also solves issue csandman#356

Reference: https://github.com/JedWatson/react-select/releases
Copy link

stackblitz bot commented Jan 24, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@rmanganiello rmanganiello changed the title Libraries - Update react-select to 5.10.0 [v5] Libraries - Update react-select to 5.10.0 Jan 24, 2025
Copy link
Owner

@csandman csandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! I'll do a release after this.

@@ -17,7 +17,8 @@
"chakra-react-select": "file:..",
"framer-motion": "^11.11.9",
"react": "^18.3.1",
"react-dom": "^18.3.1"
"react-dom": "^18.3.1",
"react-select": "5.10.0"
Copy link
Owner

@csandman csandman Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be a necessary dependency of the demo project, but I'll approve and then just remove it before I do a release. If you had just run a normal npm install in the demo folder, the newer version of react-select would have been added automatically, due to the change in the parent package.json.

@csandman csandman merged commit 4e5d0db into csandman:v5 Jan 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants