Ensure the UserId WOPI property is consistent
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glpatcern
force-pushed
the
consistent-userid
branch
from
7fca28a to
4bab85f
Compare
glpatcern
force-pushed
the
consistent-userid
branch
from
4bab85f to
2901af7
Compare
wkloucek
reviewed
Oct 12, 2021
wkloucek
reviewed
Oct 12, 2021
wkloucek
reviewed
Oct 12, 2021
wkloucek
approved these changes
Oct 12, 2021
…s for a given user
glpatcern
force-pushed
the
consistent-userid
branch
from
2901af7 to
016954a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the WOPI documentation, the
useridproperty inCheckFileInfomust be consistent over time, therefore we cannot use the Reva token for it as that's a session-based "identifier".This patch creates a
useridthat is unique and consistent. It's also reasonably short, therefore it should work with OnlyOffice as well. To be noted that the current CERNBox production, based on xrootd, does not suffer from this because we useuid:gidfor that purpose.