-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Make revad start on a per directory basis #416
Conversation
Good idea, but i prefer to run each bit in its own container so i can filter logs easy |
it is still possible to run each bit on it's own process :D, this would just make it faster to spin something up |
Hi @refs, @madsi1m, for testing/dev purposes we can have such funcionality and even with restart logic, we just need to fork one chidren process per configuration file in the directory and the master process will be a dummy process. Is not the responsibility of Reva to handle the orchestration and observability of the different services, that is delegated to enterprise-grade components like Istio/Envoy and K8s. Each tool for the right thing |
100% agree, although that was not the intention of this PR. As more people join the project we're in the case that we need to explain how to run each individual config "strategy" (strategy as in 1 single file vs I'm more than open to suggestions on how to improve this, as I believe it will streamline development. |
@refs I agree for on boarding and developing against make sense. Can you change the flag name to dev-dir instead of dir so is clear that is only for dev purposes? Thanks! |
Great idea |
@refs merged :) |
💃 thanks! |
Added a new
--dir
flag that allows for startingrevad
on any directory with a set of config files.Having a directory like so:
Would allow for
revad
to launch every service defined on each config file on the given folder like:> revad --dir ~/automation/reva/separate
This is a preliminary implementation.
It all lives under the same terminal session so all logs are printed on STDOUT. This is more intended to speed up development as it does not handle graceful shutdown just yet.